Fix infinite height when fill_height=True and footer_links=[]#13203
Open
Aarnonn wants to merge 1 commit intogradio-app:mainfrom
Open
Fix infinite height when fill_height=True and footer_links=[]#13203Aarnonn wants to merge 1 commit intogradio-app:mainfrom
Aarnonn wants to merge 1 commit intogradio-app:mainfrom
Conversation
…ight: 100% instead of min-height: 100% on .wrap when fill_height is enabled, so the flex container has a definite height constraint even without a footer element. Closes gradio-app#12992
Contributor
|
This PR has been flagged as AI generated and labelled accordingly. |
Collaborator
|
Hi @Aarnonn thanks for the pr. Can you please record a video or gif showing that this fixes the issue in spaces? |
I built a dockerized gradio on my hugginface spaces to test the PR, but I need a compiled Wheel to install there, https://huggingface.co/spaces/Carbaz/Infinite_Dockerized (Current version is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
fill_height=Trueandfooter_links=[], the Gradio interface grows to infinite height becausemin-height: 100%on.wrapdoesn't establish a definite height for flex children, and without a footer element to anchor the layout,flex-growcauses unbounded expansion.height: 100%instead ofmin-height: 100%on.wrapwhenfill_heightis enabled, giving the flex container a definite height constraint.Closes #12992
Test plan
demo/fill_height_no_footer/run.pyand verify the interface fills viewport height without infinite growthfill_height=Trueapp with default footer and verify it still works correctlypnpm test:browserforfill_height_no_footer.spec.tskumquat